eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Preflight validate

Open raymond-zhang00 opened this issue 3 years ago • 4 comments

Issue #, if available:

Description of changes: Add experimental preflight validation command and associated command validation package.

Testing (if applicable): Unit tests added to cover validation command workflow and added functions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

raymond-zhang00 avatar Aug 23 '22 16:08 raymond-zhang00

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

eks-distro-bot avatar Aug 23 '22 16:08 eks-distro-bot

Codecov Report

Merging #3119 (faaccb8) into main (efe779c) will increase coverage by 0.11%. The diff coverage is 91.60%.

:exclamation: Current head faaccb8 differs from pull request most recent head 402ae1b. Consider uploading reports for the commit 402ae1b to get more accurate results

@@            Coverage Diff             @@
##             main    #3119      +/-   ##
==========================================
+ Coverage   65.06%   65.17%   +0.11%     
==========================================
  Files         353      353              
  Lines       28562    28647      +85     
==========================================
+ Hits        18584    18671      +87     
+ Misses       8666     8661       -5     
- Partials     1312     1315       +3     
Impacted Files Coverage Δ
pkg/validations/preflightvalidations.go 0.00% <0.00%> (ø)
pkg/kubeconfig/kubeconfig.go 89.28% <53.84%> (-10.72%) :arrow_down:
pkg/validations/docker.go 49.29% <61.53%> (+11.36%) :arrow_up:
pkg/providers/validator/validate.go 78.57% <100.00%> (+28.57%) :arrow_up:
pkg/validations/createcluster/createcluster.go 100.00% <100.00%> (ø)
...idations/createvalidations/preflightvalidations.go 100.00% <100.00%> (ø)
...dations/upgradevalidations/preflightvalidations.go 100.00% <100.00%> (ø)
pkg/validations/utils.go 77.77% <100.00%> (+2.77%) :arrow_up:
pkg/api/v1alpha1/cloudstackmachineconfig_types.go 60.92% <0.00%> (-2.20%) :arrow_down:
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 30 '22 15:08 codecov[bot]

Great job! Glad to see the whole thing coming together 🚀

g-gaston avatar Aug 30 '22 22:08 g-gaston

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Sep 28 '22 21:09 eks-distro-bot