Preflight validate
Issue #, if available:
Description of changes: Add experimental preflight validation command and associated command validation package.
Testing (if applicable): Unit tests added to cover validation command workflow and added functions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Codecov Report
Merging #3119 (faaccb8) into main (efe779c) will increase coverage by
0.11%. The diff coverage is91.60%.
:exclamation: Current head faaccb8 differs from pull request most recent head 402ae1b. Consider uploading reports for the commit 402ae1b to get more accurate results
@@ Coverage Diff @@
## main #3119 +/- ##
==========================================
+ Coverage 65.06% 65.17% +0.11%
==========================================
Files 353 353
Lines 28562 28647 +85
==========================================
+ Hits 18584 18671 +87
+ Misses 8666 8661 -5
- Partials 1312 1315 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/validations/preflightvalidations.go | 0.00% <0.00%> (ø) |
|
| pkg/kubeconfig/kubeconfig.go | 89.28% <53.84%> (-10.72%) |
:arrow_down: |
| pkg/validations/docker.go | 49.29% <61.53%> (+11.36%) |
:arrow_up: |
| pkg/providers/validator/validate.go | 78.57% <100.00%> (+28.57%) |
:arrow_up: |
| pkg/validations/createcluster/createcluster.go | 100.00% <100.00%> (ø) |
|
| ...idations/createvalidations/preflightvalidations.go | 100.00% <100.00%> (ø) |
|
| ...dations/upgradevalidations/preflightvalidations.go | 100.00% <100.00%> (ø) |
|
| pkg/validations/utils.go | 77.77% <100.00%> (+2.77%) |
:arrow_up: |
| pkg/api/v1alpha1/cloudstackmachineconfig_types.go | 60.92% <0.00%> (-2.20%) |
:arrow_down: |
| ... and 3 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Great job! Glad to see the whole thing coming together 🚀
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment