Moving CloudStack to use v2 controller

[maxdrib]

Issue #, if available:

• https://github.com/aws/eks-anywhere/issues/2929
• https://github.com/aws/eks-anywhere/issues/2260

Description of changes: In order to address the issue, it seemed like migrating the Cloudstack provider off the legacy controller was the best way to enable the proper creation of the ClusterSpec. I have done so, based off the VSphere provider's example and would like some early feedback on my approach, and to make sure I haven't missed anything obvious.

Testing (if applicable): TBD

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[eks-distro-bot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[codecov[bot]]

Codecov Report

Merging #2938 (90c4971) into main (deb68ee) will decrease coverage by 0.85%. The diff coverage is 11.80%.

:exclamation: Current head 90c4971 differs from pull request most recent head 3dcc5a1. Consider uploading reports for the commit 3dcc5a1 to get more accurate results

@@            Coverage Diff             @@
##             main    #2938      +/-   ##
==========================================
- Coverage   64.74%   63.88%   -0.86%     
==========================================
  Files         352      350       -2     
  Lines       28267    27957     -310     
==========================================
- Hits        18302    17861     -441     
- Misses       8652     8789     +137     
+ Partials     1313     1307       -6     

Impacted Files	Coverage Δ
controllers/cloudstack_datacenter_controller.go	0.00% <0.00%> (ø)
controllers/factory.go	76.47% <0.00%> (-17.61%)	:arrow_down:
...g/api/v1alpha1/cloudstackdatacenterconfig_types.go	65.06% <ø> (ø)
pkg/api/v1alpha1/cloudstackmachineconfig_types.go	60.92% <ø> (ø)
pkg/dependencies/factory.go	65.97% <0.00%> (-2.32%)	:arrow_down:
pkg/providers/cloudstack/defaults.go	0.00% <0.00%> (ø)
pkg/cluster/cloudstack.go	50.00% <30.76%> (-8.63%)	:arrow_down:
controllers/cluster_controller.go	78.84% <100.00%> (+1.14%)	:arrow_up:
pkg/cluster/build.go	100.00% <100.00%> (ø)
pkg/providers/cloudstack/cloudstack.go	71.08% <100.00%> (+0.22%)	:arrow_up:
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chrisdoherty4 for approval by writing /assign @chrisdoherty4 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[TerryHowe]

Reopen if needed. Looks pretty dated and irrelevant at this point.