eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Validate VSphere User Privs

Open jonathanmeier5 opened this issue 3 years ago • 3 comments
trafficstars

Issue #, if available: #2744

Description of changes:

Add a preflight check to validate vSphere user's permissions

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jonathanmeier5 avatar Aug 09 '22 14:08 jonathanmeier5

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

eks-distro-bot avatar Aug 09 '22 14:08 eks-distro-bot

Codecov Report

Merging #2907 (ce4181a) into main (1cb67f1) will increase coverage by 0.46%. The diff coverage is 83.71%.

:exclamation: Current head ce4181a differs from pull request most recent head 7a9065b. Consider uploading reports for the commit 7a9065b to get more accurate results

@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
+ Coverage   62.25%   62.72%   +0.46%     
==========================================
  Files         334      339       +5     
  Lines       26865    27235     +370     
==========================================
+ Hits        16724    17082     +358     
+ Misses       8857     8847      -10     
- Partials     1284     1306      +22     
Impacted Files Coverage Δ
pkg/executables/executables.go 7.14% <ø> (ø)
pkg/govmomi/authorizationmanagerbuilder.go 0.00% <0.00%> (ø)
pkg/govmomi/finderbuilder.go 0.00% <0.00%> (ø)
pkg/govmomi/sessionbuilder.go 0.00% <0.00%> (ø)
pkg/govmomi/clientbuilder.go 56.00% <56.00%> (ø)
pkg/providers/vsphere/envars.go 43.75% <66.66%> (ø)
pkg/providers/vsphere/vsphere.go 65.81% <76.31%> (+0.84%) :arrow_up:
pkg/govmomi/client.go 85.13% <85.13%> (ø)
pkg/providers/vsphere/validator.go 73.21% <89.75%> (+11.53%) :arrow_up:
pkg/config/vsphereuser.go 100.00% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 09 '22 21:08 codecov[bot]

/approve

jonathanmeier5 avatar Aug 23 '22 21:08 jonathanmeier5

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathanmeier5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 23 '22 21:08 eks-distro-bot