eks-anywhere
eks-anywhere copied to clipboard
Change immutable field errors to type Forbidden
Issue #, if available:
Description of changes: Change immutable field errors to type Forbidden instead of Invalid so as to follow CAPI.
Testing (if applicable):
- Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Merging #2904 (633cb03) into main (bad9ce2) will increase coverage by
0.00%
. The diff coverage is94.44%
.
@@ Coverage Diff @@
## main #2904 +/- ##
=======================================
Coverage 62.48% 62.48%
=======================================
Files 335 335
Lines 26991 26995 +4
=======================================
+ Hits 16865 16869 +4
Misses 8839 8839
Partials 1287 1287
Impacted Files | Coverage Δ | |
---|---|---|
pkg/api/v1alpha1/cluster_webhook.go | 86.33% <84.61%> (+0.09%) |
:arrow_up: |
pkg/api/v1alpha1/awsiamconfig_webhook.go | 73.80% <100.00%> (ø) |
|
...api/v1alpha1/cloudstackdatacenterconfig_webhook.go | 79.51% <100.00%> (+0.24%) |
:arrow_up: |
pkg/api/v1alpha1/fluxconfig_webhook.go | 67.39% <100.00%> (ø) |
|
pkg/api/v1alpha1/gitopsconfig_webhook.go | 50.00% <100.00%> (ø) |
|
pkg/api/v1alpha1/oidcconfig_webhook.go | 70.83% <100.00%> (ø) |
|
...kg/api/v1alpha1/vspheredatacenterconfig_webhook.go | 75.64% <100.00%> (+0.31%) |
:arrow_up: |
pkg/api/v1alpha1/vspheremachineconfig_webhook.go | 88.67% <100.00%> (+0.10%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mitalipaygude
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mitalipaygude]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment