eks-anywhere
eks-anywhere copied to clipboard
IAM Authenticator for provider Tinkerbell
Issue #2749 Also addresses #2885
Description of changes:
Changes to enable support for aws-iam-authenticator integration for EKS-A with provider tinkerbell.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Merging #2902 (f20d69b) into main (91ee5de) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #2902 +/- ##
=======================================
Coverage 62.03% 62.03%
=======================================
Files 328 328
Lines 26452 26456 +4
=======================================
+ Hits 16409 16413 +4
Misses 8777 8777
Partials 1266 1266
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/providers/tinkerbell/template.go | 32.85% <100.00%> (+0.77%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I see the test is doing ValidateAWSIamAuth(), but I am not sure if this line is invoked, https://github.com/d8660091/eks-anywhere/blob/snow-machine-config-validate-in-reconciler/pkg/clusterapi/apibuilder.go#L205, without it, the iam authenticator would not work correctly, right?
I see the test is doing ValidateAWSIamAuth(), but I am not sure if this line is invoked, https://github.com/d8660091/eks-anywhere/blob/snow-machine-config-validate-in-reconciler/pkg/clusterapi/apibuilder.go#L205, without it, the iam authenticator would not work correctly, right?
I am actually not sure. Let me check. Right now all the e2e tests for IAM Auth invoke that validate.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gwesterfieldjr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [gwesterfieldjr]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm