eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Add snowmachineconfig check in snow reconcilier

Open d8660091 opened this issue 3 years ago β€’ 2 comments

Issue #, if available:

Description of changes: 1) Add snowmachineconfig check 2) add unit test for snow reconciler

Testing (if applicable): unit test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

d8660091 avatar Aug 08 '22 21:08 d8660091

Codecov Report

Merging #2901 (23f0ec2) into main (b1df4a1) will increase coverage by 0.02%. The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
+ Coverage   62.14%   62.16%   +0.02%     
==========================================
  Files         333      333              
  Lines       26778    26793      +15     
==========================================
+ Hits        16640    16656      +16     
+ Misses       8861     8859       -2     
- Partials     1277     1278       +1     
Impacted Files Coverage Ξ”
pkg/providers/snow/reconciler/reconciler.go 84.21% <83.33%> (+84.21%) :arrow_up:
controllers/factory.go 93.28% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 08 '22 21:08 codecov[bot]

/approve

d8660091 avatar Aug 18 '22 14:08 d8660091

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d8660091

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 18 '22 14:08 eks-distro-bot

/retest

d8660091 avatar Aug 18 '22 16:08 d8660091