eks-anywhere
eks-anywhere copied to clipboard
Use Println instead of Print for kubectl output
Description of changes: This messes up with the terminal output and the go test output when the printed text doesn't end with a break line.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from g-gaston after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Merging #2900 (fecc391) into main (6465694) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #2900 +/- ##
=======================================
Coverage 61.80% 61.80%
=======================================
Files 327 327
Lines 26457 26457
=======================================
Hits 16352 16352
Misses 8837 8837
Partials 1268 1268
| Impacted Files | Coverage Ξ | |
|---|---|---|
| pkg/curatedpackages/packageclient.go | 80.26% <100.00%> (ΓΈ) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/lgtm
@a-cool-train Is this a breaking change for you? Currently, does the output properly end with an extra line, and this would just add another?
@a-cool-train Is this a breaking change for you? Currently, does the output properly end with an extra line, and this would just add another?
This doesn't break but it adds an extra line to the output.
Closing in favor of a different fix @a-cool-train has in mind