eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Use Println instead of Print for kubectl output

Open g-gaston opened this issue 3 years ago β€’ 2 comments

Description of changes: This messes up with the terminal output and the go test output when the printed text doesn't end with a break line.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

g-gaston avatar Aug 05 '22 22:08 g-gaston

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from g-gaston after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 05 '22 22:08 eks-distro-bot

Codecov Report

Merging #2900 (fecc391) into main (6465694) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2900   +/-   ##
=======================================
  Coverage   61.80%   61.80%           
=======================================
  Files         327      327           
  Lines       26457    26457           
=======================================
  Hits        16352    16352           
  Misses       8837     8837           
  Partials     1268     1268           
Impacted Files Coverage Ξ”
pkg/curatedpackages/packageclient.go 80.26% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 22:08 codecov[bot]

/lgtm

d8660091 avatar Aug 17 '22 17:08 d8660091

@a-cool-train Is this a breaking change for you? Currently, does the output properly end with an extra line, and this would just add another?

vivek-koppuru avatar Aug 19 '22 00:08 vivek-koppuru

@a-cool-train Is this a breaking change for you? Currently, does the output properly end with an extra line, and this would just add another?

This doesn't break but it adds an extra line to the output.

a-cool-train avatar Aug 23 '22 22:08 a-cool-train

Closing in favor of a different fix @a-cool-train has in mind

g-gaston avatar Aug 23 '22 23:08 g-gaston