Fix the support bundle for docker cluster
Issue #, if available:
Description of changes: Adding the check for whether the ControlPlaneConfiguration.Endpoint is provided in the spec. Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Hi @YoyoTT. Thanks for your PR.
I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #2883 (1d869cf) into main (3b2c021) will increase coverage by
0.70%. The diff coverage is100.00%.
:exclamation: Current head 1d869cf differs from pull request most recent head 15cd2c9. Consider uploading reports for the commit 15cd2c9 to get more accurate results
@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
+ Coverage 61.57% 62.27% +0.70%
==========================================
Files 323 328 +5
Lines 26364 26545 +181
==========================================
+ Hits 16233 16532 +299
+ Misses 8860 8747 -113
+ Partials 1271 1266 -5
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/diagnostics/analyzers.go | 79.50% <100.00%> (+12.95%) |
:arrow_up: |
| pkg/diagnostics/collectors.go | 76.28% <100.00%> (+6.52%) |
:arrow_up: |
| pkg/diagnostics/diagnostic_bundle.go | 77.30% <100.00%> (-0.40%) |
:arrow_down: |
| pkg/curatedpackages/curatedpackages.go | 51.54% <0.00%> (-11.08%) |
:arrow_down: |
| ...roviders/tinkerbell/hardware/catalogue_hardware.go | 81.46% <0.00%> (-10.85%) |
:arrow_down: |
| pkg/validations/createvalidations/gitops.go | 70.00% <0.00%> (-8.58%) |
:arrow_down: |
| pkg/providers/cloudstack/validator.go | 63.94% <0.00%> (-4.98%) |
:arrow_down: |
| pkg/cluster/cloudstack.go | 58.62% <0.00%> (-3.20%) |
:arrow_down: |
| pkg/api/v1alpha1/cloudstackdatacenterconfig.go | 19.44% <0.00%> (-2.44%) |
:arrow_down: |
| pkg/executables/kubectl.go | 42.52% <0.00%> (-0.75%) |
:arrow_down: |
| ... and 45 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/hold
/unhold
/hold
/unhold
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: g-gaston
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [g-gaston]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/cherry-pick release-0.11
@g-gaston: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.
In response to this:
/cherry-pick release-0.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@g-gaston: new pull request created: #2946
In response to this:
/cherry-pick release-0.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.