eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Add --insecure flag to download images command

Open wongni opened this issue 3 years ago • 2 comments

Issue #, if available: #2878

Description of changes: Add --insecure flag to download images command

Testing (if applicable): Manual test with and without --insecure on download images command

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

wongni avatar Aug 04 '22 19:08 wongni

Codecov Report

Merging #2879 (cb2a10e) into main (91ee5de) will decrease coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
- Coverage   62.03%   61.88%   -0.15%     
==========================================
  Files         328      328              
  Lines       26452    26503      +51     
==========================================
- Hits        16409    16402       -7     
- Misses       8777     8837      +60     
+ Partials     1266     1264       -2     
Impacted Files Coverage Δ
pkg/dependencies/factory.go 67.87% <100.00%> (-0.06%) :arrow_down:
...roviders/tinkerbell/hardware/catalogue_hardware.go 81.46% <0.00%> (-10.85%) :arrow_down:
pkg/executables/kubectl.go 42.52% <0.00%> (-0.75%) :arrow_down:
pkg/providers/tinkerbell/upgrade.go 0.00% <0.00%> (ø)
pkg/providers/tinkerbell/tinkerbell.go 33.79% <0.00%> (ø)
pkg/curatedpackages/packagecontrollerclient.go 96.20% <0.00%> (+0.09%) :arrow_up:
pkg/providers/tinkerbell/template.go 32.30% <0.00%> (+0.22%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 04 '22 19:08 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 11 '22 17:08 eks-distro-bot