eks-anywhere
eks-anywhere copied to clipboard
E2E for metallb
Description of changes: MetalLB e2e tests
(Some reformatting done by golines which I can remove if need be but I think we should use golines)
Codecov Report
Merging #2863 (80280fb) into main (f670d15) will decrease coverage by
0.47%. The diff coverage is64.86%.
:exclamation: Current head 80280fb differs from pull request most recent head 52d7392. Consider uploading reports for the commit 52d7392 to get more accurate results
@@ Coverage Diff @@
## main #2863 +/- ##
==========================================
- Coverage 65.00% 64.53% -0.48%
==========================================
Files 351 353 +2
Lines 28507 28102 -405
==========================================
- Hits 18532 18136 -396
+ Misses 8662 8658 -4
+ Partials 1313 1308 -5
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/curatedpackages/bundlesource.go | 83.33% <ø> (ø) |
|
| pkg/curatedpackages/curatedpackages.go | 59.45% <0.00%> (-7.89%) |
:arrow_down: |
| pkg/curatedpackages/bundle.go | 82.55% <100.00%> (ø) |
|
| pkg/executables/helm.go | 75.63% <100.00%> (+1.99%) |
:arrow_up: |
| pkg/aws/snow.go | 67.85% <0.00%> (-25.80%) |
:arrow_down: |
| pkg/api/v1alpha1/snowdatacenterconfig_types.go | 12.12% <0.00%> (-21.97%) |
:arrow_down: |
| pkg/executables/executables.go | 7.14% <0.00%> (-17.86%) |
:arrow_down: |
| controllers/resource/reconciler.go | 47.09% <0.00%> (-9.29%) |
:arrow_down: |
| pkg/providers/snow/entry.go | 55.31% <0.00%> (-8.69%) |
:arrow_down: |
| pkg/networkutils/networkutils.go | 60.00% <0.00%> (-8.43%) |
:arrow_down: |
| ... and 53 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/hold
/unhold
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lewisdiamond by writing /assign @lewisdiamond in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Will open a new one this week with updated tests for newer versions. Closing this.