eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

E2E for metallb

Open lewisdiamond opened this issue 3 years ago • 4 comments
trafficstars

Description of changes: MetalLB e2e tests

(Some reformatting done by golines which I can remove if need be but I think we should use golines)

lewisdiamond avatar Aug 03 '22 19:08 lewisdiamond

Codecov Report

Merging #2863 (80280fb) into main (f670d15) will decrease coverage by 0.47%. The diff coverage is 64.86%.

:exclamation: Current head 80280fb differs from pull request most recent head 52d7392. Consider uploading reports for the commit 52d7392 to get more accurate results

@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
- Coverage   65.00%   64.53%   -0.48%     
==========================================
  Files         351      353       +2     
  Lines       28507    28102     -405     
==========================================
- Hits        18532    18136     -396     
+ Misses       8662     8658       -4     
+ Partials     1313     1308       -5     
Impacted Files Coverage Δ
pkg/curatedpackages/bundlesource.go 83.33% <ø> (ø)
pkg/curatedpackages/curatedpackages.go 59.45% <0.00%> (-7.89%) :arrow_down:
pkg/curatedpackages/bundle.go 82.55% <100.00%> (ø)
pkg/executables/helm.go 75.63% <100.00%> (+1.99%) :arrow_up:
pkg/aws/snow.go 67.85% <0.00%> (-25.80%) :arrow_down:
pkg/api/v1alpha1/snowdatacenterconfig_types.go 12.12% <0.00%> (-21.97%) :arrow_down:
pkg/executables/executables.go 7.14% <0.00%> (-17.86%) :arrow_down:
controllers/resource/reconciler.go 47.09% <0.00%> (-9.29%) :arrow_down:
pkg/providers/snow/entry.go 55.31% <0.00%> (-8.69%) :arrow_down:
pkg/networkutils/networkutils.go 60.00% <0.00%> (-8.43%) :arrow_down:
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 03 '22 19:08 codecov[bot]

/hold

lewisdiamond avatar Aug 04 '22 15:08 lewisdiamond

/unhold

lewisdiamond avatar Aug 04 '22 17:08 lewisdiamond

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from lewisdiamond by writing /assign @lewisdiamond in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Sep 09 '22 21:09 eks-distro-bot

Will open a new one this week with updated tests for newer versions. Closing this.

lewisdiamond avatar Dec 20 '22 14:12 lewisdiamond