eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Remove CAPA section from bundles

Open abhay-krishna opened this issue 3 years ago • 2 comments

This PR deprecates cluster-api-provider-aws types in the release API and removes it from the bundle release manifest.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

abhay-krishna avatar Aug 03 '22 17:08 abhay-krishna

Codecov Report

Merging #2861 (564867d) into main (5d70ff1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2861   +/-   ##
=======================================
  Coverage   63.75%   63.75%           
=======================================
  Files         347      347           
  Lines       27522    27522           
=======================================
  Hits        17548    17548           
  Misses       8672     8672           
  Partials     1302     1302           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 03 '22 20:08 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 30 '22 18:08 eks-distro-bot

/cherrypick release-0.11

abhay-krishna avatar Aug 30 '22 19:08 abhay-krishna

@abhay-krishna: #2861 failed to apply on top of branch "release-0.11":

Applying: Remove CAPA section from bundles
Using index info to reconstruct a base tree...
M	pkg/executables/clusterctl_test.go
A	pkg/providers/snow/reconciler/reconciler_test.go
Falling back to patching base and 3-way merge...
Removing release/pkg/bundles/cluster-api-provider-aws.go
CONFLICT (modify/delete): pkg/providers/snow/reconciler/reconciler_test.go deleted in HEAD and modified in Remove CAPA section from bundles. Version Remove CAPA section from bundles of pkg/providers/snow/reconciler/reconciler_test.go left in tree.
Auto-merging pkg/executables/clusterctl_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove CAPA section from bundles
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Aug 30 '22 19:08 eks-distro-pr-bot