eks-anywhere
eks-anywhere copied to clipboard
Load snow env vars from secret for controller
Issue #, if available:
Description of changes: Adding ability to read credentials from the credentials secret provided by the capas provider in order to construct the aws client maps.
Testing (if applicable): unit testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Codecov Report
Merging #2859 (171d010) into main (834c88e) will increase coverage by
0.52%
. The diff coverage is90.27%
.
@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
+ Coverage 61.57% 62.09% +0.52%
==========================================
Files 323 331 +8
Lines 26364 26523 +159
==========================================
+ Hits 16233 16470 +237
+ Misses 8860 8785 -75
+ Partials 1271 1268 -3
Impacted Files | Coverage Δ | |
---|---|---|
pkg/dependencies/factory.go | 67.93% <0.00%> (+1.74%) |
:arrow_up: |
pkg/providers/snow/reconciler/clientbuilder.go | 89.65% <89.65%> (ø) |
|
controllers/factory.go | 93.28% <100.00%> (ø) |
|
controllers/snow_machineconfig_controller.go | 90.62% <100.00%> (-0.15%) |
:arrow_down: |
pkg/aws/snow.go | 68.96% <100.00%> (ø) |
|
pkg/providers/snow/reconciler/credentials.go | 100.00% <100.00%> (ø) |
|
pkg/validations/createvalidations/gitops.go | 70.00% <0.00%> (-8.58%) |
:arrow_down: |
pkg/gitops/flux/client.go | 100.00% <0.00%> (ø) |
|
...dations/upgradevalidations/preflightvalidations.go | 100.00% <0.00%> (ø) |
|
pkg/controller/clientutil/delete.go | 100.00% <0.00%> (ø) |
|
... and 15 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Patch coverage is showing up as 100% right now because no test files are present in the package
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vivek-koppuru
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vivek-koppuru]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/lgtm