eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Ensure sufficient hardware for Tinkerbell upgrade

Open chrisdoherty4 opened this issue 3 years ago • 3 comments

This PR adds assertions run during upgrade to ensure we have sufficient hardware for the upgrade. It supports both Kubernetes version upgrade and scale upgrade additional hardware requirements. It does not support external etcd.

It does not attempt to ensure disks are consistent between provisioned nodes and the hardware for use in the upgrade.

The current cluster specification has not been wired to the upgrade operation as its not passed to SetupAndValidate(). The wiring is in other parts of the code base so will be on a separate PR.

chrisdoherty4 avatar Jul 11 '22 16:07 chrisdoherty4

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chrisdoherty4 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Jul 11 '22 16:07 eks-distro-bot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

eks-distro-bot avatar Jul 11 '22 16:07 eks-distro-bot

Codecov Report

Merging #2707 (c559089) into main (e724e68) will increase coverage by 0.05%. The diff coverage is 61.20%.

@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
+ Coverage   58.78%   58.83%   +0.05%     
==========================================
  Files         314      314              
  Lines       25725    25820      +95     
==========================================
+ Hits        15122    15191      +69     
- Misses       9281     9301      +20     
- Partials     1322     1328       +6     
Impacted Files Coverage Δ
pkg/providers/tinkerbell/upgrade.go 0.00% <0.00%> (ø)
pkg/providers/tinkerbell/assert.go 78.43% <79.54%> (+0.65%) :arrow_up:
pkg/providers/tinkerbell/create.go 49.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e724e68...c559089. Read the comment docs.

codecov[bot] avatar Jul 11 '22 16:07 codecov[bot]