eks-anywhere
eks-anywhere copied to clipboard
aws
Skip appending ':443: suffix to the image URLs
Issue #, if available: https://github.com/aws/eks-anywhere/issues/1602
Description of changes: Skip appending ':443: suffix to the image URLs when the registry mirror endpoint port is not specified or the same as the default HTTPS port.
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Does appending the ":443" port cause any issues with pushing the images?
Does appending the ":443" port cause any issues with pushing the images?
A certain customer registry rejects the push request. They manually tested the push after removing the suffix ":443", and it worked in their environment.
Different registries might have different behaviour when it comes to pushing images. I suggest we hold this until we research a bit more on the topic.
Does appending the ":443" port cause any issues with pushing the images?
A certain customer registry rejects the push request. They manually tested the push after removing the suffix ":443", and it worked in their environment.
Are you running the registry on port 443? Or is it running on a different port? Also, can you share the exact error you see when you try to run docker push <some-registry>:443/<some-image>
@abhay-krishna: Failed to get presubmits
In response to this:
/override eks-anywhere-release-tooling-test-presubmit
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abhay-krishna: Failed to get presubmits
In response to this:
/override eks-anywhere-release-tooling-test-presubmit
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
We are also running into the exact same issue, has there been any progress made with the research?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign ahreehong after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahreehong in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@wongni: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| eks-anywhere-release-tooling-test-presubmit | 2f9e07f3045ec6ae62ca387f28a7d4748cb4729b | link | /test eks-anywhere-release-tooling-test-presubmit |
|
| eks-anywhere-presubmit | e6b7e328d802fa3df3116c7ba9c37724d1919069 | link | true | /test eks-anywhere-presubmit |
| eks-anywhere-e2e-presubmit | e6b7e328d802fa3df3116c7ba9c37724d1919069 | link | true | /test eks-anywhere-e2e-presubmit |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.