eks-anywhere-build-tooling icon indicating copy to clipboard operation
eks-anywhere-build-tooling copied to clipboard

Published 20 hours ago • verified publisher icon aws

Lack of escaping on RHEL License username/password breaks image-builder

Open raykrueger opened this issue 2 years ago • 0 comments

What happened:

Building a rhel image with image-builder will break if the rhel license password contains special characters like $ or ! An image build will fail with a misleading message about a missing variable.

2023/01/24 16:48:31 Initiating Image Build
 Image OS: redhat
 Hypervisor: vsphere
2023/01/24 16:48:31 Executing command: /usr/bin/bash -c make -C /home/image-builder/eks-anywhere-build-tooling/projects/kubernetes-sigs/image-builder local-build-ova-rhel-8
make: Entering directory '/home/image-builder/eks-anywhere-build-tooling/projects/kubernetes-sigs/image-builder'
source /home/image-builder/eks-anywhere-build-tooling/build/lib/common.sh && retry git clone https://github.com/kubernetes-sigs/image-builder.git image-builder
Makefile:20: warning: undefined variable '9'

What you expected to happen: Expected a successful build.

How to reproduce it (as minimally and precisely as possible): Create a rhel license user with a $ in the passowrd. Create a vsphere-connection.json with that password in place. Build a rhel ova using image-builder

Anything else we need to know?:

Environment:

  • EKS Anywhere Release:
  • EKS Distro Release:

raykrueger avatar Jan 24 '23 18:01 raykrueger