deep-learning-containers icon indicating copy to clipboard operation
deep-learning-containers copied to clipboard

[huggingface_tensorflow] Update Framework version to TF2.8

Open philschmid opened this issue 2 years ago • 7 comments

GitHub Issue #, if available:

Note: If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

Description

Tests run

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

  • [ ] Revision A: sagemaker_remote_tests = "standard"
  • [ ] Revision B: sagemaker_remote_tests = "rc"
  • [ ] Revision C: sagemaker_remote_tests = "efa"

Additionally, please run the sagemaker local tests in at least one revision:

  • [ ] sagemaker_local_tests = true

DLC image/dockerfile

Additional context

Label Checklist

  • [ ] I have added the project label for this PR (<project_name> or "Improvement")

PR Checklist

  • [ ] I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • [ ] If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • [ ] If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • [ ] (If applicable) I've documented below the DLC image/dockerfile this relates to
  • [ ] (If applicable) I've documented below the tests I've run on the DLC image
  • [ ] (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • [ ] (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

Pytest Marker Checklist

  • [ ] (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • [ ] (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • [ ] (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • [ ] (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

EIA/NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • [ ] I've modified dlc_developer_config.toml in my PR branch by setting ei_mode = true, neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • [ ] I've modified dlc_developer_config.toml in my PR branch by setting benchmark_mode = true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

philschmid avatar Apr 20 '22 08:04 philschmid

@philschmid Please refer to the comment I left on this PR about test_anaconda. You can reference changes I made there for removing installations from repo.anaconda.com. These will need to be made for any future DLC releases and we are working on informing our partner teams.

kevinyang8 avatar May 16 '22 21:05 kevinyang8

/rerun

Qingzi-Lan avatar Jun 01 '22 16:06 Qingzi-Lan

/rerun

philschmid avatar Jun 01 '22 16:06 philschmid

/rerun

shantanutrip avatar Jun 30 '22 23:06 shantanutrip

/retry

shantanutrip avatar Jul 01 '22 00:07 shantanutrip

The below CodeBuild jobs are in progress: • dlc-pr-sanity-test • dlc-pr-sagemaker-test

/retry dlc-pr-sanity-test

arjkesh avatar Jul 12 '22 20:07 arjkesh

@philschmid Can you close the PR if it is not valid or move it to draft if it is not being worked currently?

tejaschumbalkar avatar Mar 22 '23 06:03 tejaschumbalkar