copilot-cli
copilot-cli copied to clipboard
fix: allow cdn certificate import without http cert import
Also fixes a bug where CDN fails to create if there are any internal ALB services deployed.
Also fixes a bug where on svc/env package we don't escape param values
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Codecov Report
Merging #4061 (91fb5ab) into mainline (3259a7a) will decrease coverage by
0.00%. The diff coverage is91.66%.
@@ Coverage Diff @@
## mainline #4061 +/- ##
============================================
- Coverage 69.09% 69.09% -0.01%
============================================
Files 248 248
Lines 35434 35453 +19
Branches 264 264
============================================
+ Hits 24483 24495 +12
- Misses 9759 9766 +7
Partials 1192 1192
| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/pkg/cli/env_package.go | 42.02% <0.00%> (-0.23%) |
:arrow_down: |
| internal/pkg/cli/deploy/env.go | 75.30% <33.33%> (-0.32%) |
:arrow_down: |
| ...ternal/pkg/deploy/cloudformation/stack/workload.go | 77.21% <94.44%> (-0.52%) |
:arrow_down: |
| cf-custom-resources/lib/unique-json-values.js | 97.50% <100.00%> (+0.20%) |
:arrow_up: |
| internal/pkg/cli/deploy/errors.go | 81.39% <100.00%> (+1.39%) |
:arrow_up: |
| internal/pkg/cli/deploy/svc.go | 48.27% <100.00%> (+0.10%) |
:arrow_up: |
| internal/pkg/manifest/validate_env.go | 85.37% <100.00%> (-0.15%) |
:arrow_down: |
| internal/pkg/template/env.go | 49.23% <100.00%> (+3.32%) |
:arrow_up: |
| ...ternal/pkg/deploy/cloudformation/cloudformation.go | 72.47% <0.00%> (-0.55%) |
:arrow_down: |
| ... and 1 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.