containers-roadmap icon indicating copy to clipboard operation
containers-roadmap copied to clipboard

[EKS][CSI Snapshot Controller] [request]: Add advanced configuration like resources, tolerations and nodeSelector, ...

Open duboisph opened this issue 1 year ago • 3 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request

The Snapshot Controller was added as EKS managed add-on via #1838. However it's missing advanced configuration like other addons.

The main problem for us is there's no support for setting tolerations and nodeSelector config. Ideally we can also specify the container's resources.

Which service(s) is this request for? EKS

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard? We use separate node pools for running system components. It's currently not possible to schedule the snapshot-controller pods to this pool.

Not being able to specify resources for evey component is also agains best practices.

Are you currently working around this issue? Just deploying as is to a non-tainted node pool.

Additional context /

Attachments /

duboisph avatar Mar 22 '24 10:03 duboisph

This would be helpful for us during the initial cluster creation. While Carpenter is not yet installed, CSI Snapshot Controller EKS addon pods are stuck in the pending state and cannot schedule on the tainted controller nodes, resulting in Terraform hangs.

shedimonG avatar Apr 17 '24 12:04 shedimonG

This is base, strange that it's not added initially. It's pretty useless right now, since there nice helm chart https://artifacthub.io/packages/helm/piraeus-charts/snapshot-controller that can be used in conjunction with terraform

Hronom avatar Jun 10 '24 20:06 Hronom

Hi all, thanks for your patience. I am happy to announce that the latest version of the snapshot-controller addon (version v8.0.0-eksbuild.1) features several new configuration options, including resources, tolerations, and node selector.

We are also looking into adding more parameters in future versions of the addon, please leave suggestions on this issue or by opening a new one.

You can use the DescribeAddonConfiguration API to see the full details of the supported parameters for any specific addon version.

ConnorJC3 avatar Jun 26 '24 15:06 ConnorJC3