containers-roadmap icon indicating copy to clipboard operation
containers-roadmap copied to clipboard

[EKS] [EFS CSI driver add-on]: deleteAccessPointRootDir flag not working

Open kordian2k opened this issue 1 year ago • 7 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request

The EFS CSI driver add-on allows to set the configuration flag deleteAccessPointRootDir. If set to true it should automatically delete files on EFS (not only the access points) once the corresponding PVC is removed. However, the files are not deleted. Moreover, the add-on does not behave like the corresponding helm chart with the controller.deleteAccessPointRootDir=true option set.

In particular, the efs-plugin container within the efs-csi-controller pod starts with the argument --delete-access-point-root-dir=false

Additional context Tested with the following setup EKS: 1.27 EFS add-on: v1.5.8-eksbuild.1 Node group: BOTTLEROCKET_x86_64, 1.14.3-764e37e4, No Fargate nodes present

kordian2k avatar Aug 22 '23 17:08 kordian2k

@kordian2k the EFS CSI Driver is based off of the upstream kubernetes community repository here - https://github.com/kubernetes-sigs/aws-efs-csi-driver, So can you please raise this issue there?

dims avatar Aug 22 '23 21:08 dims

@dims it seems the problem is within the issue not in the upstream driver. The latter works with the deleteAccessPointRootDir flag if installed via the helm chart.

kordian2k avatar Aug 23 '23 09:08 kordian2k

We are working on fix which will be deployed with version 1.6 of add-on

mikestef9 avatar Aug 24 '23 17:08 mikestef9

@mikestef9 , I'm on v1.7.0-eksbuild.1 version, and it's still not working.

In the deployment I see that - --delete-access-point-root-dir=false

shandr avatar Oct 20 '23 10:10 shandr

I can confirm that the issue is still not resolved on 1.7.0.

kordian2k avatar Oct 23 '23 16:10 kordian2k

This bug is still present in v1.7.1-eksbuild.1

relaxdiego avatar Dec 08 '23 11:12 relaxdiego

The issue still exists in v1.7.4-eksbuild.1

tsoe77 avatar Feb 13 '24 15:02 tsoe77

@dims Looking at the helm chart the value is defined under controller object, but the add-on configuration schema doesn't have it under controller, rather it's at root level (deleteAccessPointRootDir).

Fixing configuration schema should fix this.

Due to this issue, we have bunch of orphan access points costing us $.

vijaybandari avatar Feb 26 '24 05:02 vijaybandari

Still present in v1.7.5-eksbuild.2

We also have a lot of access points that should have been deleted a long time ago.

DrVaskee avatar Feb 28 '24 15:02 DrVaskee

This issue has been fixed in latest version of driver(v1.7.6) with updated schema.

mjsoyeon avatar Mar 25 '24 16:03 mjsoyeon