chalice icon indicating copy to clipboard operation
chalice copied to clipboard

Published 20 hours ago • verified publisher icon aws

Add support for Python 3.12

Open jamesls opened this issue 1 year ago • 3 comments

In addition to the mechanical changes needed to support a new Python version, I also made a few additional changes to get everything passing:

  • Removed testing cdkv1. CDK v1 is deprecated now, and while we still have code that will try and import cdkv1, we're no longer testing support for CDK v1.
  • Refresh the test/dev dependencies via pip-compile. New package versions were needed for Python 3.12 support.
  • Update the pylintrc config to match the previous behavior of earlier versions
  • Only use typing_extensions on Python 3.7, which is the only version that needs this. TypedDict was added in 3.8, and it's the only thing from that package that we use.

Closes #2086

jamesls avatar Dec 15 '23 21:12 jamesls

Looks like there's some issues with the pylint specific to python3.12 that I'll need to track down. Otherwise the feature itself seems to be working (I can deploy python3.12 apps to Lambda).

jamesls avatar Dec 15 '23 22:12 jamesls

@jamesls @devinmatte is there any update on getting this out?

iw-an avatar Jan 03 '24 12:01 iw-an

@jamesls @devinmatte seems like 3.7 support was dropped. So you are planning to remove 3.7 support and add 3.12 with this same PR?

werlex avatar Feb 07 '24 10:02 werlex

Quick update, python 3.7 has been deprecated for a few months now and haven't seen any issues in the SDK/other projects so I think we should be good to move ahead with also dropping 3.7 support. I think the simplest path here is to send a pr to drop 3.7 support, the rebase this PR on top. Working on this now, should have an update shortly.

jamesls avatar Feb 21 '24 17:02 jamesls

Py37 dropped in https://github.com/aws/chalice/pull/2095, going to rebase now and should be able to get a clean run through CI.

jamesls avatar Feb 21 '24 18:02 jamesls