chalice
chalice copied to clipboard
aws
Follow symlinks in chalicelib (resolves #696)
Resolves issue #696
Follow symlinks when scanning chalicelib directory.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Looks good, I'd just like to add a test for this in tests/functinal/test_deployer.py to make sure we don't regress on this functionality.
@jamesls I wasn't sure from your comment if you planned to do it or were asking me to, but I went ahead and added the test.
I tried to push commits one at a time so that you could see the CI failure with just the test, then pass with the fix, but it looks like they won't run without approval.
Anyway thanks for considering this.
@jamesls I thought I'd ping you again in case this slipped through the cracks.
@jamesls I wanted to ping about this PR before it goes stale. Please let me know if you're no longer interested in merging. I added the requested tests.
