chalice
chalice copied to clipboard
yaml-based configuration
We've updated all of the json configuration files to be yaml-based instead as yaml is more human readable and manageable and, you know, aws supports it. unit and functional tests are confirmed passing. We're also happy to break this up into smaller PRs as needed.
@tedivm : bump--anything else you;d like on this? I'd like to use this as the base part of adding layer-building functionality into chalice.
@2ps I just had a bit of feedback based off of my personal thoughts, but I'm not actually affiliated with this project and have no control over what gets merged.
Codecov Report
Merging #1029 into master will decrease coverage by
0.1%
. The diff coverage is91.39%
.
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 95.47% 95.37% -0.11%
==========================================
Files 27 27
Lines 4488 4520 +32
Branches 563 567 +4
==========================================
+ Hits 4285 4311 +26
- Misses 131 136 +5
- Partials 72 73 +1
Impacted Files | Coverage Δ | |
---|---|---|
chalice/pipeline.py | 98.37% <ø> (ø) |
:arrow_up: |
chalice/config.py | 95.59% <100%> (+0.11%) |
:arrow_up: |
chalice/cli/factory.py | 93.03% <100%> (+0.18%) |
:arrow_up: |
chalice/policy.py | 94% <100%> (+0.06%) |
:arrow_up: |
chalice/package.py | 100% <100%> (ø) |
:arrow_up: |
chalice/utils.py | 96.19% <84.84%> (-2.6%) |
:arrow_down: |
chalice/cli/__init__.py | 87.4% <88.88%> (ø) |
:arrow_up: |
chalice/deploy/deployer.py | 98.83% <90.9%> (-0.28%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fbed9ca...9bf9ee0. Read the comment docs.
@tedivm : understood, and the feedback was definitely appreciated.
Codecov Report
Merging #1029 into master will decrease coverage by
0.10%
. The diff coverage is91.39%
.
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 95.47% 95.37% -0.11%
==========================================
Files 27 27
Lines 4488 4520 +32
Branches 563 567 +4
==========================================
+ Hits 4285 4311 +26
- Misses 131 136 +5
- Partials 72 73 +1
Impacted Files | Coverage Δ | |
---|---|---|
chalice/pipeline.py | 98.37% <ø> (ø) |
|
chalice/utils.py | 96.19% <84.84%> (-2.60%) |
:arrow_down: |
chalice/cli/__init__.py | 87.40% <88.88%> (ø) |
|
chalice/deploy/deployer.py | 98.83% <90.90%> (-0.28%) |
:arrow_down: |
chalice/cli/factory.py | 93.03% <100.00%> (+0.18%) |
:arrow_up: |
chalice/config.py | 95.59% <100.00%> (+0.11%) |
:arrow_up: |
chalice/package.py | 100.00% <100.00%> (ø) |
|
chalice/policy.py | 94.00% <100.00%> (+0.06%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7045036...9bf9ee0. Read the comment docs.
Hi, is there any reason why this change is never merged into the repo? I think from a readibility point of view, having YAML config and IAM_POLICY_FILE
will be of tremendous help ...
I think it wasn't merged, or responded to, because this project just isn't a priority at all for amazon. I honestly forgot it even existed until you responded.