aws-toolkit-vscode icon indicating copy to clipboard operation
aws-toolkit-vscode copied to clipboard

fix(sagemaker): singleton window bug

Open aws-ajangg opened this issue 1 month ago • 3 comments

Problem

  • When user connects to space, it creates a duplicate window for the same space

Solution

  • Assign unique identifier to workspace. This will open same external window when connecting to same workspace.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-ajangg avatar Dec 04 '25 00:12 aws-ajangg

:hourglass_flowing_sand: I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

github-actions[bot] avatar Dec 04 '25 00:12 github-actions[bot]

:white_check_mark: I finished the code review, and didn't find any security or code quality issues.