aws-toolkit-vscode icon indicating copy to clipboard operation
aws-toolkit-vscode copied to clipboard

fix: validate path for getHomeDirectory

Open ivikash opened this issue 1 year ago • 6 comments

Problem

  • Users with misconfigured env variables -HOME or USERPROFILE or HOMEPATH AWS_SHARED_CREDENTIALS_FILE or AWS_CONFIG_FILE are unable to login into Amazon Q and AWS Toolkits extensions.

Solution

  • Added a isValidPath function to ensure a valid path is used for authentication

TODO

  • [x] Update fs to fsCommon because the web tests are failing. This entails updating all functions to use Promises
  • [x] Updating createVueEntries function to allow developers to build on *NIX and Windows.
  • [x] Add Logging

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ivikash avatar May 01 '24 06:05 ivikash

/retryBuilds

ivikash avatar May 07 '24 06:05 ivikash

Users on windows are unable to login to AWS Toolkits and Amazon Q extension on Windows because env variable: HOME is set incorrectly

It's not really a Windows specific issue. Any system with a misconfigured $HOME env var could have this issue.

justinmk3 avatar May 08 '24 16:05 justinmk3

/runIntegrationTests

ivikash avatar May 08 '24 17:05 ivikash