aws-toolkit-vscode icon indicating copy to clipboard operation
aws-toolkit-vscode copied to clipboard

Application Composer Issues

Open paul-uz opened this issue 1 year ago • 2 comments

  • Parameters not supported
  • Mappings not supported
  • Conditions not supported
  • Removes parameters added manually in the YML
  • Doesn't handle !Ref's in properties box for resources like HostedZone, have to keep redoing them manually
Screenshot 2024-02-08 at 15 41 46 Screenshot 2024-02-08 at 15 41 39

Example above, you can see how the !Sub function is used in the YML, is bastardised in the Composer settings window.

paul-uz avatar Feb 08 '24 15:02 paul-uz

Thanks, Paul. On the parameters being removed from the template, can you describe the steps you go through to reproduce this? We suspect this might be caused by not saving changes made directly to the template and then making changes in the canvas. To be clear, you should be able to this, but we want to make sure we understand what's triggering it.

ccaum avatar Feb 08 '24 22:02 ccaum

I'll have to try and recreate it step by step but I'm pretty sure it'd happen even after saving the template.

What's interesting is it would leave one parameter alone, despite one of the removed ones being used as a !Ref target.

paul-uz avatar Feb 08 '24 22:02 paul-uz

The fact that Application Composer removes comments is very annoying

Zizaco avatar Feb 24 '24 10:02 Zizaco

We rolled out a fix to how we're handling parameters that should address the problem you were facing. image

We've also updated our template parsing logic, so comments are better preserved now.

Thanks for the feedback, paul-uz and Zizaco!

JLargent42 avatar Apr 26 '24 22:04 JLargent42