aws-toolkit-azure-devops icon indicating copy to clipboard operation
aws-toolkit-azure-devops copied to clipboard

disableRollback added to cloudFormationExecuteChangeSet

Open bekahmark12 opened this issue 2 years ago • 9 comments

Description

Motivation

Related Issue(s), If Filed

Testing

Checklist

  • [x] I have read the README document
  • [x] I have read the CONTRIBUTING document
  • [x] My code follows the code style of this project
  • [x] I have added tests to cover my changes
  • [x] A short description of the change has been added to the changelog using the script npm run newChange

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bekahmark12 avatar Dec 08 '22 21:12 bekahmark12

Hey @bekahmark12 looks like our package-lock.json file was created using npm 7.x.x, what version are you using? I'd try updating npm and running npm i --package-lock-only to rebuild the file. If that doesn't work I'll make a PR to bump the SDK version.

JadenSimon avatar Dec 08 '22 22:12 JadenSimon

Okay I was indeed on npm v6, I updated to v7 and ran the npm i --package-lock-only command!

bekahmark12 avatar Dec 08 '22 22:12 bekahmark12

Okay great! Now try npm i [email protected] to fix the types.

JadenSimon avatar Dec 08 '22 22:12 JadenSimon

Done!

bekahmark12 avatar Dec 08 '22 23:12 bekahmark12

@bekahmark12 I'm still seeing the error so maybe a later version is needed. Looking at this history, 2.979.0 should work.

JadenSimon avatar Dec 08 '22 23:12 JadenSimon

Okay I updated the sdk to 2.979.0.

bekahmark12 avatar Dec 09 '22 16:12 bekahmark12

I'm still seeing issues related to package.json for some reason. I'll make a separate PR to update dependencies to debug further.

JadenSimon avatar Dec 12 '22 18:12 JadenSimon

Great thank you so much! :)

bekahmark12 avatar Dec 12 '22 19:12 bekahmark12

@bekahmark12

You should be able to drop your changes to package.json and package-lock.json and rebase/pull from mainline.

JadenSimon avatar Dec 14 '22 00:12 JadenSimon