aws-toolkit-azure-devops icon indicating copy to clipboard operation
aws-toolkit-azure-devops copied to clipboard

Invoke Lambda Function - Synchronous execution failure is not failing vsts release step

Open clowtown opened this issue 5 years ago • 6 comments

Describe the bug Given #137 and #147 causing a lambda execution failure (via cloudwatch logs only), VSTS release step is reporting successful completion of the lambda invocation. To reproduce

  1. Given a lambda to invoke, build release pipeline, etc.
  2. Define a release step (any agent, linux, vs2017 etc)
  3. Add step : AWS Invoke Lambda Function
  4. Provide required info and select Synchronous under Invocation Type
  5. Deploy release

Expected behavior Invoke Lambda release step should fail if the lambda execution fails.

Screenshots

Configuration: image Cloudwatch logs showing lambda invoke failed (AWS level failure, not in my code) image ADO release step showing green/success invocation image

Your Environment

  • Azure Devops Cloud Based (dev.azure.com)
  • AWS Invoke Lambda v 1.1.8 (latest from UI and seen in logs screenshot ^)

clowtown avatar May 09 '19 13:05 clowtown

@hunterwerlla - any updates on this? This seems like a broad impact bug and violates basic expectations of the task with synchronous execution. We've had a lot of false positive ci steps because the task marches on despite the lambda throwing exceptions.

clowtown avatar Jul 17 '19 14:07 clowtown

Looking at the code it seems we don't read the function error field, I agree this should be fixed.

hunterwerlla avatar Jul 17 '19 16:07 hunterwerlla

@hunterwerlla Is there any update on this? This is causing too much nasty surprises in our apps.

Sayan751 avatar Feb 23 '22 07:02 Sayan751

Would love to see it fixed, or at least a comment from the developer

CheeseNPort avatar Aug 05 '22 10:08 CheeseNPort

I'm running into this issue as well is there any response from the dev on this?

AmySchaplowsky avatar Mar 20 '24 19:03 AmySchaplowsky