aws-sdk-pandas icon indicating copy to clipboard operation
aws-sdk-pandas copied to clipboard

Add table_type property to create_ctas_table to support iceberg tables

Open Samreay opened this issue 1 year ago • 1 comments

Is your idea related to a problem? Please describe. Iceberg has a lot of nice features we'd like to use, and AWS create table as supports it now out of the box. It'd be great if the create_ctas_table allowed us to specify the table type to be either hive or iceberg as per the spec linked before.

Describe the solution you'd like create_ctas_table has a new kwarg, table_type. It would also change external_location to location based on Hive vs Iceberg table type, in addition to changing partitioned_by to partitioning

Alternatively, the function could be made more general by adding a kwarg additional_table_properties which allows end users to do what they want instead of restricting things to a subset of keywords.

I'd be happy to submit a PR for this if the concept sounds good.

Samreay avatar Sep 11 '24 00:09 Samreay

This makes sense to me and a contribution would be welcome @Samreay

jaidisido avatar Sep 16 '24 08:09 jaidisido

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed.

github-actions[bot] avatar Nov 15 '24 09:11 github-actions[bot]