aws-sdk-pandas icon indicating copy to clipboard operation
aws-sdk-pandas copied to clipboard

Athena unload_approach issues

Open jaidisido opened this issue 3 years ago • 0 comments

Describe the bug

I discovered a number of issues to address while using Athena unload_approach:

  1. unload_approach input argument does not exist for athena.read_sql_table
  2. Database and table names are not sanitised like for other approaches. For instance, a table name of amazon-reviews would fail because the Glue catalog only accepts underscore (amazon_reviews)
  3. The query results location should not be the same as the query output location. This is because the query results location must a valid location for the Athena workgroup. In other words, if the specified output location is not a valid Athena workgroup location, the query fails

How to Reproduce

  1. Attempt unload_approach in wr.athena.read_sql_table
  2. Pass in an unsanitised database or table name
  3. Pass an s3_output path which is not a valid Athena workgroup path

Expected behavior

No response

Your project

No response

Screenshots

No response

OS

Mac

Python version

3.8

AWS SDK for pandas version

2.17.0

Additional context

No response

jaidisido avatar Sep 22 '22 15:09 jaidisido