aws-sdk-pandas icon indicating copy to clipboard operation
aws-sdk-pandas copied to clipboard

Inconsistent argument names

Open vpietilainen opened this issue 2 years ago • 1 comments

Argument names seem inconsistent. In athena.read_sql_query we have arguments database and ctas_database_name, whereas in athena.create_ctas_table we have database and ctas_database. It seems that _name suffix would not be necessary.

In addition it would be nice if ctas_database could be read from environmental variables.

vpietilainen avatar Sep 16 '22 07:09 vpietilainen

Appreciate that the names are inconsistent across the methods, however changing them would be a breaking change for users. We might want to consider it in our next major version (3.0).

jaidisido avatar Sep 16 '22 08:09 jaidisido