aws-sdk-js icon indicating copy to clipboard operation
aws-sdk-js copied to clipboard

Published 20 hours ago • verified publisher icon aws

Deprecated dependency

Open filipjakubowski opened this issue 2 years ago • 3 comments

Describe the bug

Library depends on "querystring" that is being deprecated.

https://www.npmjs.com/package/querystring

Expected Behavior

"new code should use the URLSearchParams API instead"

Current Behavior

npm WARN deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

Reproduction Steps

npm install

Possible Solution

No response

Additional Information/Context

No response

SDK version used

2.1171.0

Environment details (OS name and version, etc.)

OS

filipjakubowski avatar Jul 11 '22 09:07 filipjakubowski

@filipjakubowski thanks for opening this issue, I'll discuss this with team and probably open a PR for it.

ajredniwja avatar Jul 25 '22 18:07 ajredniwja

awk-sdk also has [email protected] as dependency, which also relies on the deprecated querystring package. Would be great to find a way to remove both of those dependencies.

EvHaus avatar Aug 20 '22 01:08 EvHaus

👍

should just use globalThis.URL and globalThis.URLSearchParams instead.

jimmywarting avatar Sep 07 '22 09:09 jimmywarting

come on guys - this should be fixed !

weepy avatar Sep 23 '22 06:09 weepy

+1, happy to make a PR if someone isn't working on this. It's hacktoberfest :)

rohanrajpal avatar Oct 03 '22 05:10 rohanrajpal

Apologies I wasnt able to pick it up, feel free to open a PR for us to review thanks.

ajredniwja avatar Oct 03 '22 06:10 ajredniwja

I've added a PR to remove the dep on querystring

samuelfullerthomas avatar Oct 13 '22 10:10 samuelfullerthomas

Hey Guys. What is the status of this PR. When it is going to be merged?

samirbrkovic avatar Oct 28 '22 13:10 samirbrkovic

Trying to eliminate deprecated packages in my codebase and getting warnings about querystring because my project uses aws-sdk -- what is the status of this issue?

amy-morrill avatar May 11 '23 16:05 amy-morrill

Any news on this one?

charlesivie avatar Jun 07 '23 16:06 charlesivie

Any news on this?

gaurav-bhardwaj-ind avatar Nov 30 '23 15:11 gaurav-bhardwaj-ind

Hello everyone,

Thanks for your patience. From looking at querystring, there are no CVEs associated with it this older version. These are warnings and not errors. We are not inclined to patch this unless there's an inherent security risk.

JS SDK v2 is about to enter maintenance mode. The solution here is to upgrade to JS SDK v3.

Thanks, Ran~

RanVaknin avatar Dec 04 '23 22:12 RanVaknin

2 years later, and still this is not resolved.

mehrdad-shokri avatar Apr 07 '24 23:04 mehrdad-shokri