Missing 'aws-exec-read' and 'log-delivery-write' canned bucket ACLs in s3.d.ts

[ankon]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• [x] I've gone though Developer Guide and API reference
• [x] I've checked AWS Forums and StackOverflow for answers
• [x] I've searched for previous similar issues and didn't find any solution

Describe the bug The BucketCannedACL type could/should list the aws-exec-read and log-delivery-write values to match the documentation:

https://github.com/aws/aws-sdk-js/blob/eb36c972d7dfa729c8e9c7e2d2c806b76ffc071a/clients/s3.d.ts#L892

See https://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html#canned-acl

Is the issue in the browser/Node.js? Both (TypeScript definitions)

SDK version number v2.603.0

[ajredniwja]

Hey @ankon thank-you for reaching out to us with your issue.

The docs that you have mentioned specify canned ACLs for object related operations found here.

The code below imports typings for BucketCannedACL https://github.com/aws/aws-sdk-js/blob/eb36c972d7dfa729c8e9c7e2d2c806b76ffc071a/clients/s3.d.ts#L892

For objects:

https://github.com/aws/aws-sdk-js/blob/eb36c972d7dfa729c8e9c7e2d2c806b76ffc071a/clients/s3.d.ts#L3603

The typings are imported differently for objects and buckets.

The documentation specifies whether it applies to a bucket or an object in the applies to section.

Would be closing this issue, please re-open if you have any additional questions.

[ankon]

Sorry, I'm not understanding what you're saying.

The docs you reference clearly say that aws-exec-read is for buckets and objects, and so I would expect these to be listed explicitly here in BucketCannedACL in addition to being listed in ObjectCannedACL. log-delivery-write in the same docs is only for buckets, so I would expect it to be listed in BucketCannedACL.

(EDIT: Update for clarity)

[ankon]

Btw, @ajredniwja I cannot re-open this issue, could you please do that?

[ajredniwja]

@ankon Apologies, I didn't look at the correct section, let me mark it as a feature request.

You are welcomed to open a PR for the issue, I just need to test if the docs are wrong or we need to change the code in the SDK.

[ajredniwja]

The fix would be have to be implemented by the service team since they generate the file.

Would reach service team internally and have them change it.

[github-actions[bot]]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[ankon]

This is still a problem in master: https://github.com/aws/aws-sdk-js/blob/71b3167869cd7bbeffb4fe6f561207e5dfd75eca/clients/s3.d.ts#L953

[github-actions[bot]]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[ankon]

Sure, I don't have a problem with discussing with a bot, and updating a source reference every few weeks:

https://github.com/aws/aws-sdk-js/blob/d79f56751a3edb703db3f174806c6f794cb3b846/clients/s3.d.ts#L962

[github-actions[bot]]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[ankon]

https://github.com/aws/aws-sdk-js/blob/2dae0666ba912e0aa8f534d5291af8aafc0ca397/clients/s3.d.ts#L970

You know what's awesome? In the time this has been open the GitHub mobile experience has evolved so much that I can find that new link on my phone.

[aBurmeseDev]

Hi there - apologies for the extended delay in providing a response. It appears that this issue needs to be addressed by the service team, as these models are generated upstream by their respective teams. We had previously notified the S3 team about this, but unfortunately, no progress has been made thus far. Please feel free to reach out directly to the service team via AWS Support for further updates and assistance.

Since there are no pending action items for the SDK team, and we aim to dedicate this repository solely for SDK-related issues, I will proceed with closing this case.