aws-sdk-js-v3 icon indicating copy to clipboard operation
aws-sdk-js-v3 copied to clipboard

fix(property-provider): only reject if providers are not given to avoid debugger pause

Open omairvaiyani opened this issue 3 years ago • 1 comments

In VSCode, when you enable the breakpoint "Uncaught exceptions", the debugger falsely pauses in chain.js. This is because the method calls Promise.reject() without immediately catching it, therefore confusing the debugger.

Issue

#2263

Description

The promise now only creates and returns a rejection when truly required. The chain behaviour is kept using an initial Promise.resolve() instance.

Testing

Against my local environment. The debugger no longer pauses and the providers are still behaving as expected.

omairvaiyani avatar Jan 12 '22 11:01 omairvaiyani

This is happening on my local development instance as well. @omairvaiyani omairvaiyani did u have a workaround?

ghost avatar Jul 26 '22 21:07 ghost

https://github.com/awslabs/smithy-typescript/blob/main/packages/property-provider/src/chain.ts

should no longer be an issue since there is no longer a promise rejection happening in the chain function.

kuhe avatar Aug 17 '23 20:08 kuhe

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

github-actions[bot] avatar Sep 01 '23 00:09 github-actions[bot]