aws-sdk-js-v3 icon indicating copy to clipboard operation
aws-sdk-js-v3 copied to clipboard

[deno] config-resolver fails to build

Open christophgysin opened this issue 2 years ago • 1 comments

Describe the bug

I'm maintaining a fork of aws-sdk-js-v3 for deno.

Commit 7c6a7901f222273f7e82f169eaaf23b08c803596 adds imports and re-exports of some types. This causes deno to fail while compiling typescript, with the error:

error: TS1205 [ERROR]: Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.
export { RegionHash, PartitionHash };
         ~~~~~~~~~~

This can be fixed easily by changing the line to:

export type { RegionHash, PartitionHash };

A similar issue has previously been fixed this way.

However, I wonder if it would be acceptable to simply enable that check in the typescript config:

https://www.typescriptlang.org/tsconfig#isolatedModules

That would prevent this from happening again in the future.

christophgysin avatar Dec 27 '21 19:12 christophgysin

@christophgysin thanks for submitting.

Was able to confirm with the team that this is a bug. Will add to the backlog.

Thanks.

RanVaknin avatar Aug 03 '22 20:08 RanVaknin

Hi,

Unfortunately we are not able to prioritize Deno related work and we don't want to keep this open when we know this is not in the near future.

Apologies, Ran~

RanVaknin avatar Aug 18 '23 02:08 RanVaknin

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

github-actions[bot] avatar Sep 02 '23 00:09 github-actions[bot]