aws-sdk-js-v3 icon indicating copy to clipboard operation
aws-sdk-js-v3 copied to clipboard

CloudFront createInvalidation Typescript error (still present)

Open nprasovict opened this issue 2 years ago • 4 comments

Describe the bug

This is re-opening of the https://github.com/aws/aws-sdk-js-v3/issues/2956

Your environment

SDK version number

@aws-sdk/[email protected]

Is the issue in the browser/Node.js/ReactNative?

Node.js

Details of the browser/Node.js/ReactNative version

Paste output of npx envinfo --browsers or node -v or react-native -v

$ node -v
v12.20.1

Steps to reproduce

See https://github.com/aws/aws-sdk-js-v3/issues/2956

Observed behavior

See https://github.com/aws/aws-sdk-js-v3/issues/2956

Expected behavior

Clean compile

Screenshots

It seems that tail of the models_0.d.ts file is missing:

Selection_006

Additional context

Version 3.36.0 still works.

nprasovict avatar Dec 15 '21 22:12 nprasovict

Having the same issue in the newest version 3.67.0

mike-petersen avatar Apr 15 '22 11:04 mike-petersen

Hi @nprasovict, thanks for opening this issue. Could you please try with the latest version?, which is @aws-sdk/[email protected]. I did test it and I got not issues. Also you can see here that CreateInvalidationCommandOutput extends from CreateInvalidationResult, and here you can see that that interface contains the field Validation.

Thanks!

yenfryherrerafeliz avatar Jun 20 '22 01:06 yenfryherrerafeliz

I updated one of our projects to use 3.112.0 and I still see the part of the source code is missing. Selection_001

Also, to make sure it's not the npm on my workstation misbehaving, I downloaded npm distribution archive with:

wget $(npm view @aws-sdk/[email protected] dist.tarball)

and the file dist-types/ts3.4/models/models_0.d.ts from the archive indeed seems to be missing source code starting with line 314..

nprasovict avatar Jun 20 '22 14:06 nprasovict

Please @yenfryherrerafeliz read #3847 it looks like "strip-comments" is breaking ts3.4 declaration files in multiple packages

thefat32 avatar Aug 07 '22 12:08 thefat32

Hey thanks for opening the issue, we'll track this issue with https://github.com/aws/aws-sdk-js-v3/issues/3847

ajredniwja avatar Aug 15 '22 20:08 ajredniwja

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

github-actions[bot] avatar Aug 30 '22 00:08 github-actions[bot]