aws-sdk-js-v3 icon indicating copy to clipboard operation
aws-sdk-js-v3 copied to clipboard

Pagination operation should specify type for its third parameter

Open trivikr opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. The pagination operation currently accepts any for its third parameter. For example: https://github.com/aws/aws-sdk-js-v3/blob/07ac6be17ddbd52f638f8ed4b92b093bf7c378d1/clients/client-dynamodb/pagination/ListTablesPaginator.ts#L23-L27

The type for the third parameter is known in advance. For example, it's __HttpHandlerOptions https://github.com/aws/aws-sdk-js-v3/blob/07ac6be17ddbd52f638f8ed4b92b093bf7c378d1/clients/client-dynamodb/DynamoDB.ts#L1207

This is a problem, as it:

  • Introduces bugs like passing args in incorrect operation https://github.com/aws/aws-sdk-js-v3/issues/1665
  • Doesn't make it easy to introduce features like optional input object https://github.com/aws/aws-sdk-js-v3/issues/1664

Describe the solution you'd like The type for the third parameter in pagination should be defined. For example:

export async function* listTablesPaginate(
  config: DynamoDBPaginationConfiguration,
  input: ListTablesCommandInput,
  options?: __HttpHandlerOptions
): Paginator<ListTablesCommandOutput> {

Describe alternatives you've considered Sticking with the lack of types for third parameter in pagination.

trivikr avatar Nov 09 '20 15:11 trivikr

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

github-actions[bot] avatar Nov 10 '21 00:11 github-actions[bot]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

github-actions[bot] avatar Nov 11 '22 00:11 github-actions[bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

github-actions[bot] avatar Jul 04 '24 00:07 github-actions[bot]