aws-sdk-java icon indicating copy to clipboard operation
aws-sdk-java copied to clipboard

I corrected the log typo at the debug level

Open seheonCho opened this issue 4 years ago • 1 comments

Describe the bug

I corrected the log typo at the debug level

Expected behavior

aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/TransferProgress.java

The correct log needs to be printed out, logger.debug()

log.debug("Number of bytes transferred is more than the actual total bytes to transfer. Total number of bytes to Transfer : " + totalBytesToTransfer + ". Bytes Transferred : " + (bytesTransferred + bytes));

Current behavior

log.debug("Number of bytes transfered is more than the actual total bytes to transfer. Total number of bytes to Transfer : "
                        + totalBytesToTransfer
                        + ". Bytes Transferred : "
                        + (bytesTransferred + bytes));

Steps to Reproduce

It's a simple example.

TransferProgress transferProgress = new TransferProgress();
transferProgress.setTotalBytesToTransfer(1L);
transferProgress.updateProgress(2L);

and if, logging level for project is DEBUG,

We can receive logs with typos output from the following methods.

Possible Solution

log.debug("Number of bytes transferred is more than the actual total bytes to transfer. Total number of bytes to Transfer : "
                        + totalBytesToTransfer
                        + ". Bytes Transferred : "
                        + (bytesTransferred + bytes));

This is my Pull Request

Logs must be stamped with correct words.

Please understand that it is insufficient because it is the first issue preparation and full request. :)

Context

It doesn't affect the operation of the program, but I want the log to be printed correctly.

AWS Java SDK version used

AWS SDK for Java 1.12.92

JDK version used

openJdk 11.0.10

Operating System and version

Window10 , Mac OS Big Sur 11.5.2

seheonCho avatar Jan 12 '22 01:01 seheonCho

Hi @seheonCho thank you for your contribution. I'll change this to a documentation issue.

For the Java SDK v1 we need to incorporate the changes in our internal repository, so that after the release process they are reflected here in the Github. We'll add your change internally when we have a chance.

debora-ito avatar Feb 02 '22 22:02 debora-ito

The fix was released. Closing.

debora-ito avatar Mar 07 '24 18:03 debora-ito

This issue is now closed.

Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

github-actions[bot] avatar Mar 07 '24 18:03 github-actions[bot]