aws-sdk-java icon indicating copy to clipboard operation
aws-sdk-java copied to clipboard

Add hashcode and equals functions to S3 Bucket

Open smulikHakipod opened this issue 5 years ago • 3 comments

Adding equals and hashcode to S3 bucket

smulikHakipod avatar Dec 14 '20 10:12 smulikHakipod

@debora-ito I see that you are active here, can you please have a look and see if I need to change anything? Sorry to bother you, Thanks!

smulikHakipod avatar Dec 16 '20 08:12 smulikHakipod

@smulikHakipod can you tell us more about the motivation for this change? In reality, S3 buckets names are unique across all AWS accounts.

Also, we try to avoid customizations in the low level classes.

debora-ito avatar Dec 18 '20 22:12 debora-ito

Sure, sorry for the delay. We want to store the buckets in a Set. We sometime brings the Bucket again, and its getting duplicated in the Set. All other resources we use dont have this kind problem, like EC2 instance, Lambda and so on. This is really no consistent.

smulikHakipod avatar Dec 22 '20 07:12 smulikHakipod

Hi there, closing this PR after a long silence, sorry about that. We don't have plans to merge this at this point.

I checked the SDK for Java v2 and confirmed it has equals and hashcode implemented, so please move to use v2 if possible.

debora-ito avatar Jun 12 '23 19:06 debora-ito