aws-sdk-java icon indicating copy to clipboard operation
aws-sdk-java copied to clipboard
verified publisher icon aws

Early return in endpointDiscoveryEnabled

Open s12v opened this issue 7 years ago • 3 comments

Even when endpointDiscoveryDisabled is set to true, DEFAULT_ENDPOINT_DISCOVERY_PROVIDER still goes through default endpoint discovery providers, loads profiles, etc.

This PR changes endpointDiscoveryEnabled behavior to exit early. In case when endpoint discovery is explicitly enabled or disabled, endpointDiscoveryChainSetting would be ignored anyways.

I couldn't find any tests for this functionality.

s12v avatar Nov 28 '18 16:11 s12v

Sorry, I think we've actually fixed this one independent of this PR.

millems avatar Mar 31 '20 20:03 millems

Actually, that was just V2 that I was looking at. It may not be fixed in V1.

millems avatar Mar 31 '20 20:03 millems

would it still make sense to fix it in v1 too, what do you think, @millems ?

s12v avatar Jul 09 '21 10:07 s12v

Closing this PR, we don't have plans to merge this at this moment.

debora-ito avatar May 09 '23 00:05 debora-ito