aws
DynamoDB PaginatedList should use IDynamoDBMapper interface instead of concrete DynamoDBMapper
The SDK team has reviewed the feature request list for V1 and this one looks like a great candidate for a community PR, which we’ll help merge in and support.
This looks pretty dirt simple to do. looking for some contribution work in the evenings. I'll need some assistance with unit tests, for some reason they hate me. The V2 has a wiki for developers, but can't seem to find the wiki for the V1 repo.
For the fix, I plan on deprecating the constructors that use concrete class and add new ones that accept the interface. Probably don't even need to go that far really, but will fix based on team's preference.
Edit: And then I see internal concrete methods called. not so dirt simple :)
I’m not actively working on it. I recall it being a cascade of changes and didn’t see a super simple fix that I liked. Worth another pair of eyes I suppose.
Sent from my iPhone
On Jan 10, 2022, at 4:57 PM, Shay Dratler @.***> wrote:
Hi @debora-ito , @kmbotts Is this still open for the grab ?
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.