aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

Ignore unknown properties on endpoints in endpoint rules.

Open alextwoods opened this issue 7 months ago • 1 comments

Warn instead of raising an exception on unknown endpoint properties.

Motivation and Context

The Rules engine Endpoint Object Properties member is defined as an arbitrary Map<string, object> and to support forwards compatibility/extensibility and comply with the specification, we should not be failing when an unknown property is present in the rules.

Modifications

  • Change the exception to a logger warning when an unknown (at this point, anything other than authSchemes) property is encountered in an Endpoint object.

Testing

Added new test case with endpoint rules with unknown property.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have read the CONTRIBUTING document
  • [x] Local run of mvn install succeeds
  • [x] My code follows the code style of this project
  • [x] I have added tests to cover my changes
  • [x] All new and existing tests passed
  • [x] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

  • [x] I confirm that this pull request can be released under the Apache 2 license

alextwoods avatar May 28 '25 21:05 alextwoods

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

github-actions[bot] avatar Jun 20 '25 18:06 github-actions[bot]