aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard
verified publisher icon aws

Add presignHeadObjec method to S3Presigner

Open tmccombs opened this issue 1 year ago • 6 comments

So that you can sign HEAD requests to S3.

Fixes #5473 Fixes #5276

Motivation and Context

Provide a way to create signed urls for HEAD requests to s3

Modifications

Add a presignHeadObject method to S3Presigner

Checklist

  • [x] I have read the CONTRIBUTING document
  • [ ] Local run of mvn install succeeds
  • [x] My code follows the code style of this project
  • [x] My change requires a change to the Javadoc documentation
  • [x] I have updated the Javadoc documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] All new and existing tests passed
  • [x] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • [x] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [x] I confirm that this pull request can be released under the Apache 2 license

tmccombs avatar Aug 06 '24 20:08 tmccombs

I needed this feature so I used this feature branch to see if it works. But I had to make more code changes to it to make it work. image

rhollander73 avatar Feb 03 '25 11:02 rhollander73

@rhollander73 would you mind pushing up your changes, or sending a diff?

tmccombs avatar Feb 03 '25 15:02 tmccombs

@debora-ito Is this something worth finishing? Or is it unlikely to get merged?

tmccombs avatar Feb 03 '25 16:02 tmccombs

presigned-head-object.patch I have created a patch in IntelliJ. I cannot push my changes to this feature branch or create a new branch from this feature branch and push my changes to it.

rhollander73 avatar Feb 05 '25 13:02 rhollander73

@tmccombs I did sent an IntelliJ patch in the previous comment. Are you able to install this patch?

rhollander73 avatar Feb 06 '25 08:02 rhollander73

I've incorporated your patch into my branch

tmccombs avatar Feb 07 '25 00:02 tmccombs

Hi @tmccombs

Thanks for raising the PR. Since this PR is about a year old I took the liberty of raising a new one with your changes, and additional support for HeadBucket as well and test coverage that was missing. I added attribution in the changelog so it would reflect the work you've already done.

Thanks again for your help! Ran~

RanVaknin avatar Jun 04 '25 18:06 RanVaknin