aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

Use modifyRequest lifecycle hook for auth scheme

Open dagnir opened this issue 9 months ago • 1 comments

This changes gives other interceptors the opportunity to update auth scheme related execution attributes such as IDENTITY_PROVIDERS before the auth scheme is actually resolved. This is necessary because the auth scheme should not be changed after it has been resolved as intermediate interceptors could be using the resolved auth scheme, such as the accound ID in endpoint resolution.

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [ ] I have read the CONTRIBUTING document
  • [ ] Local run of mvn install succeeds
  • [ ] My code follows the code style of this project
  • [ ] My change requires a change to the Javadoc documentation
  • [ ] I have updated the Javadoc documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] All new and existing tests passed
  • [ ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • [ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [ ] I confirm that this pull request can be released under the Apache 2 license

dagnir avatar May 24 '24 20:05 dagnir