aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

Add S3 payload signing test with SRA

Open gosar opened this issue 2 years ago • 1 comments

Motivation and Context

As discussed in https://github.com/aws/aws-sdk-java-v2/pull/4499#issuecomment-1739915201, the existing test uses execution attribute to enable payload signing. The execution attribute is SdkProtectedApi and also deprecated with SRA. Adding test for SRA way of enabling payload signing for S3.

Modifications

Add test

Testing

New test passes

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have read the CONTRIBUTING document
  • [ ] Local run of mvn install succeeds
  • [x] My code follows the code style of this project
  • [ ] My change requires a change to the Javadoc documentation
  • [ ] I have updated the Javadoc documentation accordingly
  • [x] I have added tests to cover my changes
  • [x] All new and existing tests passed
  • [ ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • [ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [x] I confirm that this pull request can be released under the Apache 2 license

gosar avatar Dec 29 '23 22:12 gosar

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 29 '23 23:12 sonarqubecloud[bot]