aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard
verified publisher icon aws

Unstable tests on master

Open StephenFlavin opened this issue 2 years ago • 7 comments

Describe the bug

mvn install was failing on SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe and ProfileFileSupplierTest#aggregate_duplicateOptionsGivenReloadingProfileFirst_preservesPrecedence there may be more.

I came across this while doing the PR checklist.

Expected Behavior

the master branch has repeatable tests that don't fail

Current Behavior

a couple of flakey test preventing builds, the flakeyness might be the result of a wider issue

Reproduction Steps

Run SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe on repeat

Possible Solution

No response

Additional Information/Context

No response

AWS Java SDK version used

2.20.50-SNAPSHOT

JDK version used

openjdk 11.0.16.1 & openjdk 19.0.1

Operating System and version

macOs 13.2.1 (22D68)

StephenFlavin avatar Apr 20 '23 15:04 StephenFlavin

Are they flaky or they fail every time? Can you post the logs with the error?

debora-ito avatar Apr 21 '23 01:04 debora-ito

flaky sorry if I was unclear. Screenshot 2023-04-21 at 08 50 32

Screenshot 2023-04-21 at 08 54 32

StephenFlavin avatar Apr 21 '23 07:04 StephenFlavin

@StephenFlavin Thank you for the logs. We'll change them to make less flaky.

debora-ito avatar Apr 21 '23 20:04 debora-ito

also CachedSupplierTest.nonBlockingPrefetchStrategyHasOneMinuteMinimumByDefault Screenshot 2023-05-23 at 14 21 55

StephenFlavin avatar May 23 '23 11:05 StephenFlavin

just spotted this failing on the github runner for the last release https://github.com/aws/aws-sdk-java-v2/actions/runs/5516177879/jobs/10057255204#step:3:43966

StephenFlavin avatar Jul 11 '23 09:07 StephenFlavin

SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe and ProfileFileSupplierTest#aggregate_duplicateOptionsGivenReloadingProfileFirst_preservesPrecedence flakiness were fixed and merged.

Will take a look at CachedSupplierTest.nonBlockingPrefetchStrategyHasOneMinuteMinimumByDefault.

debora-ito avatar Jul 26 '23 20:07 debora-ito

We did a workforce to remove flaky tests from the builds. @StephenFlavin let us know if this issue persists in latest SDK version.

debora-ito avatar Jun 10 '25 00:06 debora-ito

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

github-actions[bot] avatar Jun 19 '25 21:06 github-actions[bot]