aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

Add locale converter to enhanced DynamoDB client

Open thomasturrell opened this issue 2 years ago • 2 comments

Motivation and Context

The Java Locale is currently not supported by the DynamoDB client.

Modifications

Used UriAttributeConverter as a template to create LocaleAttributeConverter.

Testing

Added tests and tested locally

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have read the CONTRIBUTING document
  • [x] Local run of mvn install succeeds
  • [x] My code follows the code style of this project
  • [ ] My change requires a change to the Javadoc documentation
  • [ ] I have updated the Javadoc documentation accordingly
  • [x] I have added tests to cover my changes
  • [x] All new and existing tests passed
  • [x] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • [ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [x] I confirm that this pull request can be released under the Apache 2 license

thomasturrell avatar Jul 31 '22 14:07 thomasturrell

@debora-ito could you help me with the process to get this pull request reviewed and hopefully merged? I have not contributed to this project before.

thomasturrell avatar Aug 05 '22 09:08 thomasturrell

Yes! Sorry for the delay, will bring this up to the team.

debora-ito avatar Aug 05 '22 19:08 debora-ito

@thomasturrell let us know if you want to continue with this review.

debora-ito avatar Oct 10 '22 21:10 debora-ito

@thomasturrell let us know if you want to continue with this review.

I will fix the issue and return to you. Thank you for the reminder.

thomasturrell avatar Oct 11 '22 14:10 thomasturrell

@debora-ito I believe that the failing test is now fixed.

thomasturrell avatar Oct 11 '22 21:10 thomasturrell

Hi @thomasturrell thank you for addressing the comment. We will take a look shortly.

zoewangg avatar Oct 11 '22 22:10 zoewangg

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 1 Code Smell

96.2% 96.2% Coverage 0.0% 0.0% Duplication

I believe that the code smell is acceptable because the public modifier is used in all of the other tests in this class. In my opinion, this new test should be consist with the other tests. I suggest that the unnecessary public modifiers should be removed in a separate pull request.

thomasturrell avatar Oct 12 '22 08:10 thomasturrell

@all-contributors please add @thomasturrell for code.

debora-ito avatar Oct 13 '22 17:10 debora-ito

@debora-ito

I've put up a pull request to add @thomasturrell! :tada:

allcontributors[bot] avatar Oct 13 '22 17:10 allcontributors[bot]