aws-sdk-java-v2
aws-sdk-java-v2 copied to clipboard
Add locale converter to enhanced DynamoDB client
Motivation and Context
The Java Locale is currently not supported by the DynamoDB client.
Modifications
Used UriAttributeConverter as a template to create LocaleAttributeConverter.
Testing
Added tests and tested locally
Screenshots (if appropriate)
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
Checklist
- [x] I have read the CONTRIBUTING document
- [x] Local run of
mvn install
succeeds - [x] My code follows the code style of this project
- [ ] My change requires a change to the Javadoc documentation
- [ ] I have updated the Javadoc documentation accordingly
- [x] I have added tests to cover my changes
- [x] All new and existing tests passed
- [x] I have added a changelog entry. Adding a new entry must be accomplished by running the
scripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes. - [ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog
License
- [x] I confirm that this pull request can be released under the Apache 2 license
@debora-ito could you help me with the process to get this pull request reviewed and hopefully merged? I have not contributed to this project before.
Yes! Sorry for the delay, will bring this up to the team.
@thomasturrell let us know if you want to continue with this review.
@thomasturrell let us know if you want to continue with this review.
I will fix the issue and return to you. Thank you for the reminder.
@debora-ito I believe that the failing test is now fixed.
Hi @thomasturrell thank you for addressing the comment. We will take a look shortly.
Kudos, SonarCloud Quality Gate passed!
I believe that the code smell is acceptable because the public modifier is used in all of the other tests in this class. In my opinion, this new test should be consist with the other tests. I suggest that the unnecessary public modifiers should be removed in a separate pull request.
@all-contributors please add @thomasturrell for code.