aws-sdk-go icon indicating copy to clipboard operation
aws-sdk-go copied to clipboard

File/directory is opened but is not being closed.

Open amankaur27 opened this issue 1 year ago • 4 comments

Describe the bug

I found some places where a file/directory is opened but it is not closed and it may lead to resource overhead issue. Consider following files:

aws-sdk-go/private/model/cli/api-info/api-info.go aws-sdk-go/example/aws/credentials/plugin/plugin.go

Expected Behavior

The opened files/directories should be closed with defer.

Current Behavior

Right now, these are not closed.

Reproduction Steps

Possible Solution

No response

Additional Information/Context

No response

SDK version used

v1.38.64

Environment details (Version of Go (go version)? OS name and version, etc.)

go version 1.19.5, linux (Ubuntu 22.04.2 LTS)

amankaur27 avatar Jul 14 '23 07:07 amankaur27

Hi @amankaur27 ,

Looks reasonable. Do you want to take a stab at raising a PR?

Thanks, Ran~

RanVaknin avatar Jul 18 '23 20:07 RanVaknin

Hello @RanVaknin , Thanks for your reply. I am new to this platform. Could you explain what you mean by PR ?

amankaur27 avatar Jul 20 '23 03:07 amankaur27

@amankaur27 Ran asks whether you would like to fix this bug and open a pull request (aka PR) including the fix so that they merge your fix to the main branch.

ziyaddin avatar Jul 22 '23 19:07 ziyaddin

Hi @RanVaknin, Can you assigned this to me, I would like to work on this, if this issue is still open?

manojmaurya17 avatar Oct 22 '23 13:10 manojmaurya17

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Apr 16 '24 12:04 github-actions[bot]