Incorrect documentation of PrivateDnsHostnameTypeOnLaunch

[johngmyers]

Describe the issue with documentation

The documentation of ModifySubnetAttribyteInput.PrivateDnsHostnameTypeOnLaunch incorrectly states that IPv4 only subnets cannot use instance ID based hostnames.

To Reproduce (observed behavior)

Modify the PrivateDnsHostnameTypeOnLaunch attribute of a subnet without an IPv6 address to the value ec2.HostnameTypeResourceName. Create an instance in the subnet and examine its private DNS hostname.

Expected behavior

I expect the documentation to state that this combination works, especially since it does work.

Screenshots

Additional context

[KaibaLopez]

Hi @johngmyers , Can you point me to the place where the documentation is wrong?

[johngmyers]

@KaibaLopez in service/ec2/api.go around line 116742, the second sentence is incorrect.:

	// The type of hostnames to assign to instances in the subnet at launch. For
	// IPv4 only subnets, an instance DNS name must be based on the instance IPv4
	// address. For IPv6 only subnets, an instance DNS name must be based on the
	// instance ID. For dual-stack subnets, you can specify whether DNS names use
	// the instance IPv4 address or the instance ID.
	PrivateDnsHostnameTypeOnLaunch *string `type:"string" enum:"HostnameType"`

[github-actions[bot]]

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.