aws-rfdk icon indicating copy to clipboard operation
aws-rfdk copied to clipboard

feat(aws-rfdk) Upgrade JSII to 1.7.0 to bump xmldom to 0.83. Address …

Open leongdl opened this issue 1 year ago • 0 comments

Upgrade JSII to 1.7.0 to bump xmldom to 0.83. Address security issue.

Dependabot alert: https://github.com/aws/aws-rfdk/security/dependabot/19

Updating xmldom to 0.83+ requires updating JSII and related tools to the latest 1.7.0.

Upgrade steps:

  • From docker: yarn upgrade jsii jsii-pacmak jsii-reflect
  • Ran ./build.sh from root
  • Ran ./pack.sh from root
  • Ran yarn build+test from ./packages/aws-rfdk

Test output:

aws-rfdk: =============================== Coverage summary ===============================
aws-rfdk: Statements   : 97.92% ( 3305/3375 )
aws-rfdk: Branches     : 95.14% ( 1038/1091 )
aws-rfdk: Functions    : 96.98% ( 514/530 )
aws-rfdk: Lines        : 98.09% ( 3189/3251 )
aws-rfdk: ================================================================================
aws-rfdk: Test Suites: 62 passed, 62 total
aws-rfdk: Tests:       1276 passed, 1276 total
aws-rfdk: Snapshots:   0 total
aws-rfdk: Time:        678.814 s

yarn test output

=============================== Coverage summary ===============================
Statements   : 97.92% ( 3305/3375 )
Branches     : 95.14% ( 1038/1091 )
Functions    : 96.98% ( 514/530 )
Lines        : 98.09% ( 3189/3251 )
================================================================================

Test Suites: 62 passed, 62 total
Tests:       1276 passed, 1276 total

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

leongdl avatar Oct 26 '22 23:10 leongdl