aws-pdk
aws-pdk copied to clipboard
[BUG] Upgrading core pdk code results in reverting back to the original versions.
Describe the bug
Attempting to upgrade pdk, pdk dependencies and projen roles back to previous versions.
Expected Behavior
aws/pdk should be upgraded to latest and projen should be upgraded to latest.
Current Behavior
Relevant bits of the upgrade logs included from reproduction steps below.
-
@aws/pdk
goes from0.23.35
to0.23.38
then back to0.23.35
> @demo/[email protected] upgrade UpgradeDemo
> pnpm exec projen upgrade
πΎ upgrade | pnpm dlx npm-check-updates@16 --upgrade --target=minor --peer --dep=dev,peer,prod,optional --filter=eslint-config-prettier,eslint-import-resolver-typescript,eslint-plugin-import,eslint-plugin-prettier,npm-check-updates,prettier,ts-node,typescript,@aws-cdk/aws-cognito-identitypool-alpha,aws-cdk-lib,cdk-nag
Progress: removed
Using pnpm
Upgrading UpgradeDemo/package.json
[====================] 11/11 100%
[====================] 3/3 100%
aws-cdk-lib 2.137.0 β 2.142.1
cdk-nag 2.28.92 β 2.28.119
npm-check-updates 16.14.18 β 16.14.20
Run pnpm install to install new versions.
πΎ upgrade | pnpm i --no-frozen-lockfile
Scope: all 3 workspace projects
Progress: removed
dependencies:
- aws-cdk-lib 2.137.0
+ aws-cdk-lib 2.142.1
- cdk-nag 2.28.92
+ cdk-nag 2.28.119
devDependencies:
- npm-check-updates 16.14.18
+ npm-check-updates 16.14.20
Done in 4.7s
πΎ upgrade | pnpm update @aws/pdk @types/node @typescript-eslint/eslint-plugin @typescript-eslint/parser constructs eslint-config-prettier eslint-import-resolver-typescript eslint-plugin-import eslint-plugin-prettier eslint npm-check-updates nx prettier projen syncpack ts-node typescript @aws-cdk/aws-cognito-identitypool-alpha aws-cdk-lib cdk-nag
Progress: removed
dependencies:
- @aws-cdk/aws-cognito-identitypool-alpha 2.134.0-alpha.0
+ @aws-cdk/aws-cognito-identitypool-alpha 2.142.1-alpha.0
devDependencies:
- @aws/pdk 0.23.35
+ @aws/pdk 0.23.38
- @types/node 18.19.26
+ @types/node 18.19.33 (20.12.12 is available)
- syncpack 12.3.0
+ syncpack 12.3.2
Done in 2.2s
πΎ upgrade | pnpm exec projen
πΎ default | ts-node --project tsconfig.dev.json .projenrc.ts
πΎ Installing dependencies...
πΎ install | pnpm i --no-frozen-lockfile
Scope: all 3 workspace projects
Progress: removed
devDependencies:
- @aws/pdk 0.23.38
+ @aws/pdk 0.23.35 (0.23.38 is available)
Done in 4.4s
-
projen
goes from0.79.24
to0.81.15
back to0.79.27
> @demo/[email protected] upgrade-deps UpgradeDemo
> pnpm exec projen upgrade-deps
πΎ upgrade-deps | pnpm exec nx run-many --target=upgrade --output-style=stream --nx-bail --projects=@demo/api,@demo/api-model
> NX The following projects do not have a configuration for any of the provided targets ("upgrade")
- @demo/api
- @demo/api-model
> NX No projects with target upgrade for 0 projects were run
> NX Successfully ran target upgrade for 0 projects
πΎ upgrade-deps | pnpm exec npm-check-updates --deep --rejectVersion 0.0.0 -u --dep prod,dev,peer,optional,bundle --target=minor
Using pnpm
Upgrading UpgradeDemo/package.json
[====================] 20/20 100%
constructs ^10.0.0 β ^10.3.0
projen ^0.79.24 β ^0.81.15
Upgrading UpgradeDemo/packages/api/generated/infrastructure/typescript/package.json
[====================] 8/8 100%
@aws/pdk ^0.23.35 β ^0.23.38
aws-cdk-lib ^2.137.0 β ^2.142.1
cdk-nag ^2.28.92 β ^2.28.119
projen ^0.79.24 β ^0.81.15
Upgrading UpgradeDemo/packages/api/generated/runtime/typescript/package.json
[====================] 8/8 100%
constructs ^10.0.0 β ^10.3.0
projen ^0.79.24 β ^0.81.15
Run pnpm install to install new versions.
πΎ upgrade-deps | pnpm exec syncpack fix-mismatches
= Default Version Group ========================================================
18 β already valid
30 β fixed
β package.json
β packages/api/generated/infrastructure/typescript/package.json
β packages/api/generated/runtime/typescript/package.json
πΎ upgrade-deps | rm pnpm-lock.yaml
πΎ upgrade-deps | pnpm i
Scope: all 3 workspace projects
βWARNβ 5 deprecated subdependencies found: @npmcli/[email protected], [email protected], [email protected], [email protected], [email protected]
Packages: +4 -25
++++-------------------------
Progress: resolved 637, reused 629, downloaded 0, added 0, done
devDependencies:
- @aws/pdk 0.23.35
+ @aws/pdk 0.23.38
- projen 0.79.27
+ projen 0.81.15
βWARNβ Issues with peer dependencies found
.
βββ¬ @aws/pdk 0.23.38
βββ β unmet peer projen@^0.79.24: found 0.81.15
packages/api/generated/infrastructure/typescript
βββ¬ @aws/pdk 0.23.38
βββ β unmet peer projen@^0.79.24: found 0.81.15
Done in 6s
πΎ upgrade-deps | pnpm exec projen
πΎ default | ts-node --project tsconfig.dev.json .projenrc.ts
πΎ Installing dependencies...
πΎ install | pnpm i --no-frozen-lockfile
Scope: all 3 workspace projects
βWARNβ 5 deprecated subdependencies found: @npmcli/[email protected], [email protected], [email protected], [email protected], [email protected]
Packages: +3 -2
+++--
Progress: resolved 637, reused 629, downloaded 0, added 0, done
devDependencies:
- projen 0.81.15
+ projen 0.79.27 (0.81.15 is available)
Done in 3.7s
- Re-synthing projen seems irrelevant, dependencies are not updated.
Reproduction Steps
Using these versions: @aws/pdk 0.23.35
& projen 0.79.24
Running the following steps does not upgrade pdk/projen:
-
pnpm run upgrade
-
pnpm upgrade-deps
-
pnpm default
Possible Solution
No response
Additional Information/Context
A demo repo has been setup, hopefully it behaves the same in other environments:
https://github.com/raurir/projen-pdk-upgrade-issue/
PDK version used
0.23.35
What languages are you seeing this issue on?
Typescript
Environment details (OS name and version, etc.)
Macos 14.4